Replace beem with lighthive #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
brianoflondon
commented
Jan 7, 2022
| ) | ||
| # TODO: Should we periodically check if the account is allowed | ||
| # and shut down if not? | ||
| if self.server_account not in allowed: | ||
| logging.error( | ||
| f"Account @{self.server_account} not authorised to send Podpings" | ||
| ) | ||
| except AccountDoesNotExistsException: | ||
| except 45: |
There was a problem hiding this comment.
I don't really know how to do error trapping properly and play nice with loops. Basic checks work.
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Add handling for more than 5 custom_jsons from one account in a given block. The retry condition will trigger. I can't think of a good way to write a test condition for this
I'm not sure this test is really doing what I want, but lighthive seems to handle it.
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Also fix the description since it doesn't render as markdown on pypi
…stindex-org/podping-hivewriter into feature/1.1/Test_Lighthive
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Signed-off-by: Brian of London <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lighthive used to post custom_jsons - more work incoming to remove beem from checking for server settings
Closes #28