-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added live episodes to the front page #197
Conversation
Hrm. The logic on this might be too flaky to use. The PC2.0 stream didn't appear in |
What do you need to make it work better? More metadata about the stream from the API? |
@daveajones Adding the live status (pending, live, ended) and/or start/end dates to the Alternatively, you could add a Also, what conditions cause |
No Agenda isn't showing up in the live feed today: EDIT: Now it's showing up as of 1:36pm today: |
I love this idea! Have you been having better luck with it lately @ericpp ? Would be happy to help test it, we go live tonight around 9 central US |
Hey Sir @SpencerPearson! Unfortunately no, I'm still hitting two issues with the Podcast Index API:
My current code works around the second issue by removing podcasts after an hour of being posted. The first issue would still cause confusion for podcasters who would expect their podcast to show up after going live. |
I'm working on solving this issue by including liveItem's in the normal /episodes/by____ response. Will update this when ready. |
@daveajones Excellent! That would let me show live shows on the podcast page as well. |
0a99fc9
to
b613aeb
Compare
The code now checks the Also, the |
@ericpp Ok to close this or are you still working on it? |
@daveajones I'm not comfortable deploying it in the current state. It needs a specific API call that returns live episodes based on most recent timestamp rather than id. |
10-4 |
Shows live episodes posted within the past hour on the front page of the website. Live episodes appear before recent episodes in the carousel and the user can switch between them by clicking on the normal left/right buttons.
This code makes the assumption that live episodes posted within the past hour are currently live. The API doesn't currently provide the live status or start and end times of live episodes.