Fix problem with spin() and spinOnce() for X Window System #5252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a problem in VTK (versions 9.0.2, 9.0.3, and 9.1.0), the Start() function of the vtkXRenderWindowInteractor crashes when Terminate() is called. This leads to spin() and spinOnce() crashing. This commit adds a fixed version of the vtkXRenderWindowInteractor that is used for the previously mentioned VTK versions. Additionally, it is necessary to change spinOnce() from Start()+timer+Terminate() to ProcessEvents()+sleep since Terminate() closes the window in future VTK versions (and the fixed vtkXRenderWindowInteractor). The changes are limited to the affected versions and the X Window System to avoid regressions for e.g. Windows and MacOS
mvieth
added
module: visualization
changelog: fix
larshg
approved these changes
May 19, 2022
|
Thank you very much for this! |
yasamoka
pushed a commit
to yasamoka/pcl
that referenced
this pull request
Jun 17, 2022
…dLibrary#5252) * Fix problem with spin() and spinOnce() for X Window System Due to a problem in VTK (versions 9.0.2, 9.0.3, and 9.1.0), the Start() function of the vtkXRenderWindowInteractor crashes when Terminate() is called. This leads to spin() and spinOnce() crashing. This commit adds a fixed version of the vtkXRenderWindowInteractor that is used for the previously mentioned VTK versions. Additionally, it is necessary to change spinOnce() from Start()+timer+Terminate() to ProcessEvents()+sleep since Terminate() closes the window in future VTK versions (and the fixed vtkXRenderWindowInteractor). The changes are limited to the affected versions and the X Window System to avoid regressions for e.g. Windows and MacOS * Do not always compile the fixed X rwi * Only include header if necessary
nikhilm
added a commit
to nikhilm/SFND_Lidar_Obstacle_Detection
that referenced
this pull request
Nov 7, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a problem in VTK (versions 9.0.2, 9.0.3, and 9.1.0), the Start() function of the vtkXRenderWindowInteractor crashes when Terminate() is called. This leads to spin() and spinOnce() crashing.
This commit adds a fixed version of the vtkXRenderWindowInteractor that is used for the previously mentioned VTK versions.
Additionally, it is necessary to change spinOnce() from Start()+timer+Terminate() to ProcessEvents()+sleep since Terminate() closes the window in future VTK versions (and the fixed vtkXRenderWindowInteractor).
The changes are limited to the affected versions and the X Window System to avoid regressions for e.g. Windows and MacOS