Add TypeScript declarations to paper-input. #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimvdLippe
approved these changes
Mar 8, 2018
paper-input-addon-behavior.d.ts
Outdated
| * value: The input value. | ||
| * invalid: True if the input value is invalid. | ||
| */ | ||
| update(state: {inputElement?: Element|null, value?: string, invalid: boolean}): void; |
There was a problem hiding this comment.
Nit: put invalid first as that one is required.
paper-input-behavior.d.ts
Outdated
| _ariaDescribedBy: string|null|undefined; | ||
| _ariaLabelledBy: string|null|undefined; | ||
| _inputId: string|null|undefined; | ||
| hostAttributes: object|null; |
There was a problem hiding this comment.
All these should be private
paper-input-behavior.d.ts
Outdated
| * Returns a reference to the focusable element. | ||
| * | ||
| */ | ||
| readonly _focusableElement: any; |
There was a problem hiding this comment.
Should both be HTMLElement
paper-input-container.d.ts
Outdated
| _handleValue(inputElement: any): void; | ||
| _handleValueAndAutoValidate(inputElement: any): void; | ||
| _onIronInputValidate(event: any): void; | ||
| _invalidChanged(): void; |
There was a problem hiding this comment.
Lots of methods which should be private I suppose? We can remove these later.
There was a problem hiding this comment.
Done (some of them anyway).
paper-input.d.ts
Outdated
| * to correctly focus the native input. | ||
| * | ||
| */ | ||
| readonly _focusableElement: any; |
paper-textarea.d.ts
Outdated
| */ | ||
| maxRows: number|null|undefined; | ||
| selectionStart: any; | ||
| selectionEnd: any; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds TypeScript declarations generated by https://github.com/Polymer/gen-typescript-declarations/
These declarations can be re-generated by running
npm run update-types.Tracker: https://github.com/Polymer/gen-typescript-declarations/issues/79