Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send slack messages for new Business application or application put on hold #102

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

F-OBrien
Copy link
Collaborator

Description

Send messages to slack for Netki CDD Application placed on hold or when new business applications are received

Breaking Changes

N/A

JIRA Link

N/A

Checklist

  • Updated the Readme.md (if required) ? N/A

@F-OBrien F-OBrien requested a review from a team as a code owner August 22, 2024 16:33
apps/cdd-backend/src/cdd-worker/cdd.processor.ts Outdated Show resolved Hide resolved
apps/cdd-backend/src/cdd-worker/cdd.processor.ts Outdated Show resolved Hide resolved
apps/cdd-backend/src/cdd-worker/cdd.processor.ts Outdated Show resolved Hide resolved
apps/cdd-backend/src/cdd-worker/cdd.processor.ts Outdated Show resolved Hide resolved
apps/cdd-backend/src/test-utils/mocks.ts Outdated Show resolved Hide resolved
@polymath-eric
Copy link
Contributor

Refactoring to a service should fix your failing case where the actual slack app was failing construction.

IMO its OK to skip unit tests for the Slack service itself and add a coverage ignore comment, but if you do want to add them you will need to mock out the import with jest with this type of syntax:

jest.mock(
  '~/api/entities/Asset/Fungible',
  require('~/testUtils/mocks/entities').mockFungibleAssetModule('~/api/entities/Asset/Fungible')
);

@F-OBrien F-OBrien changed the title WIP: Send slack messages for new Business application or application put on hold Send slack messages for new Business application or application put on hold Aug 23, 2024
- update cdd.processor.ts to use new service
- add new env's to worker config file and .env.sample.worker
- update and add tests
@F-OBrien F-OBrien force-pushed the slack-notifications branch from f184c88 to e6b1fa5 Compare August 26, 2024 18:18
@F-OBrien F-OBrien merged commit e6b1fa5 into main Aug 27, 2024
5 checks passed
@F-OBrien F-OBrien deleted the slack-notifications branch August 27, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants