feat(feature-flags): Enable bootstrapping the library #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allows for initialising the library with a distinctID, and/or feature flags as well. This id is treated as an anonymous ID, unless you explicitly say that it's not.
This allows for immediate flag availability on load, and makes possible to do things like: redirect pages based on feature flags (which wouldn't have been possible earlier, since the flags take some time to load)
@mariusandra , @Twixes , have a look here for how I expect this to be used: PostHog/posthog#11704 -> just a PoC, to help review this PR, if you want interface changes, etc. etc.
...
Tested by running locally with the PoC PR, see everything works as expected.
Checklist