feat(person-on-events): Enable CI to run using both old and new queries #9814
Conversation
| i=index | ||
| ) | ||
| ) | ||
|
|
||
| # use person properties mapping to populate person properties in given event | ||
| if person_mapping and person_mapping.get(event["distinct_id"]): |
There was a problem hiding this comment.
Going to need to handle group properties in some way like this too
There was a problem hiding this comment.
Aye, leaving it for a PR where groups get tackled, as that provides an easy way to test the changes are sound.
Right now, since there's no code actually using the instance setting, the new CI stuff still runs the old code, with extra event properties populated.
|
Another thing is snapshots won't be nice. The person on event tests will all expect different snapshots |
These tests would now disregard snapshot changes. Good call. Have added direction in the main issue to include atleast one test with new snapshots. |
| ENABLE_ACTOR_ON_EVENTS_TEAMS=all pytest ee \ | ||
| --splits ${{ inputs.concurrency }} \ | ||
| --group ${{ inputs.group }} \ | ||
| --snapshot-update |
There was a problem hiding this comment.
What's supposed to be happening here? Not sure how this is preventing snapshots
There was a problem hiding this comment.
Oh I see, these updates aren't committed so it never has any impact
* master: refactor(ingestion): Make `KAFKA_ENABLED` true by default and set `KAFKA_HOSTS` default (#9844) feat(apps): transpile frontend.tsx (#9828) feat: show api call status when adding insights to dashboards (#9817) feat: track metrics on zapier hook firings (#9866) fix(onboarding): instrumentation (#9845) feat(whitelabel-shared-dashboard): Hide branding on shared dashboards paid (#9849) fix(apps): plugin source quickfix (#9862) refactor(plugin-server): Remove `ts-jest`, use `jest.mocked` (#9861) refactor(plugin-server): Trigger public jobs with graphile insted of celery queue (#9811) chore: upgrade pip tools (#9859) feat(apps): plugin source in its own model, part 2 (#9854) chore: Update sprint_planning_retro.md (#9791) feat(apps): plugin source in its own model, part 1 (#9853) feat(matrix): Add option to save `simulate_matrix` like `setup_dev` (#9836) fix(cohort): add mapping from event to person (#9841) feat(person-on-events): Enable CI to run using both old and new queries (#9814)
Problem
All the groundwork needed for person on events querying
Step 1 of many, as referenced here: #9802
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?