Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Current behaviour
The overall build and run pipelines are a mess, both for this and the snapshotter.
projects.json
file being created and populated at run time is a hacky way to merge configuration sources. Similarily, the docker image does not have a default entrypoint, but does expect a very specific command in order to run at all, which is instead defined in thedocker-compose.yaml
manifest under thecommand
service fields.New expected behaviour
This is a small PR that aims to make the docker image a little easier to work with outside of the provided
docker-compose
from the snapshotter repo.Change logs
config/settings.json
is now in the Dockerfile instead of thesnapshotter_autofill.sh
script, which shouldn't break the overall command chain but would make it possible for someone to mount a customsettings.json
file at runtime and is overall better practice since that settings file is simply a default that is common to all container imagesinit_processes.sh
todocker-entrypoint.sh
, which is a standard name easier to work with from the outsidesnapshotter_autofill.sh
inside of the newly renameddocker-entrypoint.sh
, again making it easier to work with the container outside of the provideddocker-compose
ENTRYPOINT
to theDockerfile
to ensure correct default behavior