This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Added support for Exclusive flag parameter which ensures the a value is the EXCLUSIVE value in a given key. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is the EXCLUSIVE value in a given key.
Codecov Report
@@ Coverage Diff @@
## dev #64 +/- ##
===================================
- Coverage 83% 83% -1%
===================================
Files 19 19
Lines 2751 2780 +29
Branches 4 5 +1
===================================
+ Hits 2294 2313 +19
- Misses 453 462 +9
- Partials 4 5 +1 |
…is the EXCLUSIVE value in a given key.
TravisEz13
reviewed
Jun 12, 2017
| @@ -332,6 +363,20 @@ function Set-TargetResource | |||
| $null = Remove-Item -Path $Key -Recurse -Force | |||
| } | |||
| } | |||
| else | |||
| { | |||
| if ($Exclusive) | |||
There was a problem hiding this comment.
Add a comment about why are removing:
- key exist
- value name not specified
- Exclusive specified
So remove any values.
|
Discussing some design patterns with Bobby offline. |
kwirkykat
added
the
on hold
|
Are there any updates on this PR or has it been abandoned for the time being? |
|
We were discussing design implications with Mark. Since Mark has moved on, let me loop @mgreenegit in. |
|
@mgreenegit Can you glance at this PR so we can remove the 'on hold' label, and then we can review it. @bobbytreed Are you still able to work on this issue if we can remove the 'on hold' label? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other resources (like UserRightsAssignment) perform this operation with the FORCE parameter. Here the FORCE parameter is used to remove Keys that have subkeys. Other names can be considered, but a flag is the most logical option. The impact is low for this change as current implementations would not at all be affected.
Fixes #63
This change is