-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove UTF-8 BOM from text files #1567
base: main
Are you sure you want to change the base?
Conversation
27640fc
to
a083f59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xtqqczze Sorry for the late review. Can you please elaborate why you need this change or why it would be beneficial to this repo?
My main concern is with this part; Windows PowerShell isn't going to like BOM-less UTF-8 |
Instead, ps*1 files should probably have a BOM and other text files should not |
The configuration should match that, but generally looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change ps*1 files to UTF-8 with BOM, adapt the editor config to reflect that and regenerate the resource file to resolve the conflict
@xtqqczze after looking through your approach in this PR and thinking about some of the particulars of this repo, I've opened #1665, which goes a bit further and tries to clean up some of the strangeness in the PSSA repo. In particular, it specifies more settings, uses UTF-8 with BOM for PowerShell files, and makes sure test assets (some of which are deliberately encoded or formatted differently) are put in a protected assets directory |
PR Summary
PR Checklist
.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.