Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace words with racial connotation (use allowlist and blocklist as an alternative) #1604

Merged

Conversation

bergmeister
Copy link
Collaborator

PR Summary

This does not replace all words with a racial connotation because one word is the setting name of the PSAvoidUsingCmdletAliases rule. Therefore an alternative setting name is being added, whilst allowing the current one to still work. The idea is that we give users time to adapt in the next version but completely remove the setting with a racial connotation in the version after that.

PR Checklist

@bergmeister bergmeister marked this pull request as ready for review October 25, 2020 20:50
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only worry here is that this is a public configuration key, so that changing its name will break existing configurations

@rjmholt
Copy link
Contributor

rjmholt commented Nov 3, 2020

My only worry here is that this is a public configuration key, so that changing its name will break existing configurations

Oh I see from your description that this is an alternative!

@rjmholt rjmholt merged commit 4857578 into PowerShell:master Nov 3, 2020
@bergmeister
Copy link
Collaborator Author

Yes, it is an alternative/alias for the existing settings but once a new version of pssa is released with that, which would give people time to adapt I am tempted to remove the original setting name completely in the following release but that's a discussion for another day, which will probably not happen until in 6 months time....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants