-
Notifications
You must be signed in to change notification settings - Fork 937
Add space between VSC_BRANCH_ICON and branch name. #618
Conversation
@diraol - Thanks so much for submitting this PR! I apologize it's taken me so long to respond - the last month has been a bit crazy for me. @diraol @runmad - This issue has actually come up a few times. When I first released P9k, we actually did not have a space, then I added it a little bit ago and it remained for a few releases before enough people complained that I pulled it back out again. The primary issue with putting the space in the code is that it makes it difficult for those that don't want it to remove it. Going the opposite direction, though, if there is not a space in the code, it's very easy to add one by modifying the If you look at your changeset, for example, with the space built-in, there, there is no way for someone to remove it other than modifying the P9k code directly. I personally prefer having a space, to be honest, and I would like to settle on a solution that works well for everyone. @dritter @rjorgenson @docwhat - Curious about your thoughts on this topic. |
I think leaving the space out is best. Unicode 9 solves a lot of problems with characters that need double space. |
I think supporting Unicode 9 is better. It automatically makes wide glyphs take two spaces in mono spaced fonts. |
@docwhat I do not have any idea what is the necessary effort to support Unicode 9. Any tips on that? Also, why not supporting the latest release of Unicode (10) instead of (9)? |
https://github.com/jquast/wcwidth has some info. As well as iterm2 for Mac. Basically: emoji can be double width in 9. This makes things interesting if you need to know how wide text is. |
Hm, so it's not really clear to me what actually needs to be done in P9k to support UTF-9. @diraol - So I just put the space back. I actually started receiving e-mails from folks about this, and they raised the good point that, previously, the default was to have the space. I've returned it back to the old default, and anyone who doesn't want the space can remove it by resetting the icon. |
FIX #617