Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

Add support for both AWS_PROFILE and AWS_DEFAULT_PROFILE #667

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

akranga
Copy link
Contributor

@akranga akranga commented Nov 7, 2017

AWS_PROFILE env var has been respected by AWS client as well as AWS_DEFAULT_PROFILE. See here: http://docs.aws.amazon.com/cli/latest/userguide/cli-multiple-profiles.html

This small change adds AWS_PROFILE in coalesce with AWS_DEFAULT_PROFILE

@Loki22
Copy link

Loki22 commented Nov 10, 2017

Yes please add this. I think AWS_PROFILE is the correct one anyway, at least for most things CLI related that use common libraries. The link below is the latest docs and they do not even reference AWS_DEFAULT_PROFILE, so perhaps that was deprecated.

http://docs.aws.amazon.com/cli/latest/userguide/cli-environment.html

@akranga
Copy link
Contributor Author

akranga commented Nov 10, 2017

Waiting for PR to be merged

@bhilburn
Copy link
Member

bhilburn commented Nov 10, 2017

Thanks so much for submitting this fix, @akranga! I really appreciate it, and thanks for linking to the relevant docs! This is now in master and next!

Welcome to P9k =)

@bhilburn bhilburn merged commit 87acc51 into Powerlevel9k:master Nov 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants