Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

Fixed Issue with whitespaces in path. #686

Merged
merged 2 commits into from
Dec 14, 2017
Merged

Conversation

Corwynt
Copy link

@Corwynt Corwynt commented Nov 27, 2017

Whitespaces in Path lead to an error in ´prompt_dir()`. To fix this, the IFS variable which defines the split-chars for assignments is temporarily set to an empty string.

@Zankuroh
Copy link

It's not a full fix (it doesn't show error msg but the path is not complete) but thank you anyway

@Corwynt
Copy link
Author

Corwynt commented Nov 27, 2017

@Nuntis can you tell me which path doesn't work for you?

@Zankuroh
Copy link

Zankuroh commented Nov 27, 2017

@Corwynt Wow, my bad, it's my fault, I didn't reload my shell u_u
It works perfectly !
Thank you :D

@pucicu
Copy link

pucicu commented Nov 27, 2017

Great! Thank you very much! Works well now.

@bhilburn
Copy link
Member

bhilburn commented Dec 5, 2017

Hey @Corwynt! Thanks so much for submitting this PR! The dir segment is pretty heavily used, so I do want to make sure we get this bugfix merged.

Currently, this PR is breaking unit tests, and it looks like it may be due to the use of local. Have a look:
https://travis-ci.org/bhilburn/powerlevel9k/builds/308097509

What version of ZSH did you test this with locally? I wonder if the behavior has changed.

@Corwynt
Copy link
Author

Corwynt commented Dec 5, 2017

@bhilburn The Tests seem to run now, without an error. I was missing some quotes around a variable assignment

@bhilburn
Copy link
Member

@Corwynt - Thanks for the fix! Looks great.

Thanks again for putting this PR together, and welcome to P9k! =)

@bhilburn bhilburn merged commit c50eb9c into Powerlevel9k:master Dec 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants