[Bugfix] Resolve #918 Transparent background

[JulienPivard]

Before function getColorCode consider value 'none' like a bad value and search for another value that could match.
Now function getColorCode consider value 'none' like a good value and no longer seeks to replace it.
When it's use to set background the segment become transparent.

[dritter]

Hi @JulienPivard !
Good catch there. Thanks for submitting a PR.

[dritter]

It would be more readable to write that as elif [[ "${(L)1}" == "none" ]]

[JulienPivard]

Yes I add to the next commit

[bhilburn]

@julienfalque - Thanks so much for putting together this PR! We'll be able to get this in our next release, v0.6.6, which, I'm really happy about.

@onaforeignshore - Do you mean outside of the if / elif / else structure? I'm a fan of keeping that conditional flow to prevent unneeded evaluations, although the lines couldn't be concatenated to:

  # Check if value is none with any case.
  elif [[ "${(L)1}" == "none" ]]; then
    echo -n 'none'

[JulienPivard]

You're welcome
@bhilburn you missed your tag ^^

[onaforeignshore]

@bhilburn Just FYI.

Testing: [[ "${(L)s}" == "none" ]]
( repeat 1000000; do; [[ "${(L)s}" == "none" ]]; done; )  0.84s user 0.00s system 99% cpu 0.845 total

Testing: [[ ${s} == [Nn][Oo][Nn][Ee] ]]
( repeat 1000000; do; [[ ${s} == [Nn][Oo][Nn][Ee] ]]; done; )  1.37s user 0.00s system 99% cpu 1.370 total

[JulienPivard]

it's already changed in 5ce384f

[JulienPivard]

@dritter If I change the line

if [[ "$1" == "NONE" || "$2" == "NONE" ]]; then

to

if [[ "${(L)1}" == "NONE" || "${(L)2}" == "NONE" ]]; then

I have that result :

And if I remove the test I have the same result. For a better rendering I think we should keep that test,
or use an other keyword to designate the first segment.

[onaforeignshore]

@JulienPivard The (L) in ${(L)1} means convert to lowercase, which means your test will always fail as NONE will never be equal to none. To test for NONE you need ${(U)1} instead.

[JulienPivard]

@onaforeignshore thanks
It's worse with :

if [[ "${(U)1}" == "NONE" || "${(U)2}" == "NONE" ]]; then

result :

[dritter]

I fixed a problem in combination with newlines in #960 . Could you try out that PR, and and see if the problem exists there?
And if it does, could you share your configuration with us?

[JulienPivard]

@dritter It's work.

[bhilburn]

Merged into master as part of #944, and will be part of the v0.6.6 release!