This repository has been archived by the owner on Apr 24, 2020. It is now read-only.
Add tests #934
Merged
Add tests #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally - Add a fourth parameter to prompt_battery for better testability. This parameter is the root prefix, so we can use our own test batteries.
Change regular expressions to a more compatible format.
There are now specific tests for git and hg
This fixes an error on travis, because there is no sudo allowed. We could allow it, but I think it is better to mock sudo anyway.
|
Merged into master as part of #944, and will be part of the v0.6.6 release! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers three topics:
Add tests
Obviously, this is the main purpose of this PR. The Tests are mainly extracted from #344.
Improve Test Structure
I improved the Tests stylistically and prepared them for the upcoming performance optimisations. This means two things:
Test on many ZSH versions
The Tests are executed by Travis on ZSH 5.5.1, 5.5, 5.4.2, 5.4.1, 5.3.1, 5.3, 5.2, 5.1.1 both on Linux and MacOS.
Caveats
There are a few Changes in
powerlevel9k.zsh-theme:grep -o "[0-9.]*togrep -o -E "[0-9.]+).vi_modesegment (changed fromdefaulttowhite)detect_virtsegment to print nothing if nothing was detected.This PR aims on
master, but if there are too many changes in behaviour, we could change base tonext..