Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

[Discussion] Change bright colors to old version #959

Merged
merged 4 commits into from
Sep 5, 2018

Conversation

dritter
Copy link
Member

@dritter dritter commented Aug 17, 2018

This should fix the second issue in #955 that @DuncanHuang brought up.

The colors were changed in v0.6.5. This PR updates the colors to the previous version.

So the colors red, green, yellow, blue, magenta, cyan and white point the bright colors:

'black'   '000'
'red'     '001'
'green'   '002'
'yellow'  '003'
'blue'    '004'
'magenta' '005'
'cyan'    '006'
'white'   '007'

I did a separate PR for this, because this needs a bit of discussion. The page that was the source for the color names lists the colors mentioned above in the range of 8-15, like they are in v.0.6.5. But that means that users who upgrade may have to change their color definitions. That is why we need to discuss this here. The commit to look at is 8e966e3

In short:

  • Option A
    Change colors like in this PR. This means that users who upgrade P9K from an old Version (pre v0.6.5) get the same colors as before, but if they upgrade from v0.6.5, colors change. Second downside is that we turn away from other color definitions.

  • Option B
    Leave colors as they are. This means that users who upgrade P9K from an old Version (pre v0.6.5) get different colors.

Before this, there was no difference in that colors, as we always used
the bright color codes.
@dritter dritter changed the title Fix color values [Discussion] Should we change bright colors to old version Aug 17, 2018
@dritter dritter mentioned this pull request Aug 17, 2018
@AuroraWright
Copy link

The new color scheme looks terrible on Solarized Dark (on the macOS Terminal.app at least). Colors are muted and dark-ish, and I basically need to customize most blocks (including the "dir" one) for them to stand out.

@bhilburn
Copy link
Member

bhilburn commented Sep 5, 2018

@dritter - Thanks so much for putting this together, explaining the situation, and laying out the options. I would like to revert back to the previous colors; breaking existing configs is never a good plan, IMO.

It looks like this PR was filed before I had actually merged the v066 staging branch into master, so there is a bit of git logistics to go through, here. I'll get that sorted and then get this branch merged. =)

@AuroraWright - Thanks for your input here, by the way!

@dritter dritter changed the title [Discussion] Should we change bright colors to old version [Discussion] Change bright colors to old version Sep 5, 2018
@bhilburn bhilburn merged commit 96f3c1d into Powerlevel9k:master Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants