This repository has been archived by the owner on Apr 24, 2020. It is now read-only.
[Discussion] Change bright colors to old version #959
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the second issue in #955 that @DuncanHuang brought up.
The colors were changed in
v0.6.5
. This PR updates the colors to the previous version.So the colors
red
,green
,yellow
,blue
,magenta
,cyan
andwhite
point the bright colors:I did a separate PR for this, because this needs a bit of discussion. The page that was the source for the color names lists the colors mentioned above in the range of 8-15, like they are in
v.0.6.5
. But that means that users who upgrade may have to change their color definitions. That is why we need to discuss this here. The commit to look at is 8e966e3In short:
Option A
Change colors like in this PR. This means that users who upgrade P9K from an old Version (pre
v0.6.5
) get the same colors as before, but if they upgrade fromv0.6.5
, colors change. Second downside is that we turn away from other color definitions.Option B
Leave colors as they are. This means that users who upgrade P9K from an old Version (pre
v0.6.5
) get different colors.