Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

[Bugfix] Fix for #974 #981

Merged
merged 2 commits into from
Jan 23, 2019
Merged

[Bugfix] Fix for #974 #981

merged 2 commits into from
Jan 23, 2019

Conversation

pgierz
Copy link
Contributor

@pgierz pgierz commented Sep 7, 2018

Hi, I have a quick fix for #974; we simply check if a file /etc/os-release exists, and grep for the appropriate release id if it does. If it does not the case statement reverts back to the default linux icon. This isn't so nice if you do in face have one of the pre-made icons (e.g. centos), but if the files are named inconsistently between different hosts, I don't see a good way of getting around that.

@bhilburn
Copy link
Member

bhilburn commented Oct 8, 2018

@pgierz - Great idea! The only thing I want to change about this PR is the use of grep - we are trying to remove as many calls to external programs as possible in the next codebase.

@onaforeignshore @rjorgenson - Any chance you can suggest a replacement pure-ZSH alternative to the use of grep, here? =)

@bhilburn bhilburn changed the base branch from master to next October 8, 2018 21:49
@bhilburn bhilburn added the Hacktoberfest Recommended Issue for Hacktoberfest! label Oct 8, 2018
@bhilburn bhilburn changed the base branch from next to master October 8, 2018 21:50
@bhilburn bhilburn added the master label Oct 8, 2018
@bhilburn
Copy link
Member

bhilburn commented Oct 8, 2018

Okay, I just realized that #988 fixed this in the next branch, hah. So, the issue is fixed in next, but not in master. Also, the fix indeed still uses grep.

If we are able to replace the use of grep in this PR, I'd like to merge this into master and then replace the same code in next with this change, as well.

functions/utilities.zsh Outdated Show resolved Hide resolved
@dritter dritter merged commit 6ccdfdf into Powerlevel9k:master Jan 23, 2019
@dritter
Copy link
Member

dritter commented Jan 23, 2019

Hmm. Once again the travis tests on OSX hangs. Merging anyway. Thx @pgierz .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Hacktoberfest Recommended Issue for Hacktoberfest! master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants