Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pymupdf the default tool for generating svg and png #2186

Closed
wants to merge 3 commits into from

Conversation

oscarlevin
Copy link
Member

from latex-image. The original method is still available, behind a pymupdf switch that now defaults to true.

@rbeezer
Copy link
Collaborator

rbeezer commented Jun 30, 2024

This is looking good, though I have not yet taken it for a drive. Thanks for preserving the old behavior. I think it needs two related things, and one follow-on:

  • Documentation should stop talking about installing/using pdf2svg and PyMuPDF should be added as a dependency for the pretext/pretext script running in a Python virtual environment.
  • Lots of project files and pretext.cfg files in the repository pointing at pdf2svg. These need to change so the website update script won't be impeded.
  • I'm only likely to update SVG images for the sample article as a test. A subsequent PR could update others in the repository.

@oscarlevin
Copy link
Member Author

Added two commits to address your first two bullets. Also added a new issue to eventually completely remove convert (#2188 )

rbeezer added a commit that referenced this pull request Jul 17, 2024
@rbeezer
Copy link
Collaborator

rbeezer commented Jul 17, 2024

Thanks, Oscar! Sorry for the long delay. I thought this was a bit more involved than it really is/was. Merged as-is, but for one whitespace character.

I'll suggest @Alex-Jordan remove the final dependency on convert.

Great to get rid of all those instructions in the Guide about one-off software installations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants