-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for @stdin on <program>. #2232
base: master
Are you sure you want to change the base?
Conversation
Thanks for noticing that this is not implemented. Runestone Author Guide says:
|
Fixed the tabs. I think having only one |
If you set |
I'm just curious about the timeline on this request. We're about to start the semester in a little under three weeks, and it would be great to have this feature available by then. Thanks! |
The fact that we need a non-empty value makes this a bit nebulous. Two attributes - a mandatory switch and an optional value feels better to me. We don't worry about erro-handling so much; the schema can express correct formulations precisely, so that is not at issue. Once that is settled, this needs documentation to move forward. I'll be off-duty for the final two weeks of your three-week window. |
Just replied to a Myabe this should be an element. |
I guess the thought process of the guy who wrote the javascript was why would you go to the trouble of adding a
Yep, an empty string is "falsey" in Javascript. It would be easy enough for me to check if So easy in fact that I've already made the change, which I think actually counts as fixing a bug (given the documentation) |
A related idea that I've been wrestling with is how to make a stderr in outputs. I'm not sure that this is quite what you all are talking about above. But it would be useful in my book to distinguish stdout from stderr in my tags, since they really are different channels. |
It looks like Brad's bug fix makes it so there would only need to be one @stdin attribute/element and not a default value attribute/element. I'm not sure whether an attribute or element is better for this particular feature. It may be theoretically easier to make newlines if it's in an element, but I'm not sure. |
Add @stdin attribute to element. Outputs a data-stdin attribute in the resulting HTML.