Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a PreFigure sidebyside into the sample-article #2305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidaustinm
Copy link
Contributor

This adds two annotated PreFigure diagrams in a sidebyside in the sample article. I don't think it's ready to be merged, but I wanted to illustrate some ways in which PreTeXt and diagcess are not getting along.

  1. The @widths and @margins attributes of the sidebyside seem not to be fully respected, and the result of changing the values of those attributes doesn't seem entirely predictable.
  2. The relative size of the two diagrams changes when the dimensions of one of the SVGs changes, which I don't believe should happen. The version here looks alright (after a bit of fiddling), but changing @dimensions="(300,200)" from (200,200) in the first diagram will change the relative size of the two diagrams and sometimes one diagram will bleed over into the other.
  3. I'm wondering if the navigation instructions could be placed in the margin. It's a relatively long piece of text "Diagram Exploration Keyboard Controls" and when it breaks into two lines under one of the diagrams, the vertical alignment is affected. In a sidebyside, we shouldn't need it twice.

@davidaustinm
Copy link
Contributor Author

PS: Grab the prefig nightly before compiling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant