This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
#118: fix run_namespaced_job to read the condition status rather than the number of succeeded/failed pods in a job #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasFiorentini
changed the title
1 task
|
@WillRaphaelson hi there, do you have some time to review this PR? 🙏 |
chrisguidry
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Thanks @NicholasFiorentini, looking at the conditions is definitely more accurate, thank you!
|
Thanks @chrisguidry ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118.
This PR changes the behaviour of
run_namespaced_job:In case of a failure, the exception now reports the reason reported by Kubernetes to help debug the issue.
Checklist
pre-commitchecks.Includes screenshots of documentation updates.not applicable