Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow the specification of parameter overrides per schedule #2919

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Feb 4, 2025

This PR updates the ScheduleFormModal to provide an input for parameter overrides for an individual schedule.

By default, schedules start with no overrides, but users can choose which parameters should be overridden. After choosing a parameter to override, the form will update to include fields for that parameter with the default value defined on the base deployment.

Here's what it looks like in action:

Screen.Recording.2025-02-05.at.11.59.52.AM.mov

Closes OSS-6191

@desertaxle desertaxle marked this pull request as ready for review February 5, 2025 18:05
@desertaxle desertaxle requested a review from a team as a code owner February 5, 2025 18:05
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from the UX perspective - LGTM!

@znicholasbrown
Copy link
Contributor

cooool

@desertaxle desertaxle merged commit 264a2f5 into main Feb 5, 2025
2 checks passed
@desertaxle desertaxle deleted the create-deployment-schedule-with-parameters branch February 5, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants