Check if we're on the main thread when using mock sigterm handler in tests #11552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serinamarie
added
the
development
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chrisguidry
approved these changes
Jan 4, 2024
zzstoatzz
approved these changes
Jan 4, 2024
This was referenced Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #11548
Should close #10895
We missed a spot where we're using the
mock_sigterm_handlerfixture in our tests and we sometimes face intermittent failures resulting in theValueError: signal only works in main thread of the main interpreterwe've been seeing lately.Checklist
<link to issue>"maintenance,fix,feature,enhancement,docs.For documentation changes:
netlify.tomlfor files that are removed or renamed