Lint for significant drops who may have surprising lifetimes #1
Conversation
PrestonFrom
changed the title
There was a problem hiding this comment.
While I have a few more things that we shoukd iterate on, (message text, more precise spans, documentation) I think we should merge it and then keep working on it in follow ups. This should put less of a burden on you and give everyone something to experiment with, even if it's not yet where we want it to be at the end
library/core/src/marker.rs
Outdated
| /// Trait to help linters look for drops that happen at unexpected times | ||
| /// Any type whose drop has a significant side effect can impl this trait | ||
| /// so linters can let users know if it has a potentially surprising lifetime. | ||
| #[stable(feature = "significant_drop", since = "1.60.0")] |
| } else { | ||
| found_significant_drop | ||
| } | ||
| } |
There was a problem hiding this comment.
You probably need to format these files, but I'm unsure how to do that in the clippy copy inside the rustc repo
There was a problem hiding this comment.
I checked the clippy repo documentation, but I couldn't find anything on formatting, so I ran cargo fmt. I'm not sure if that will be satisfactory or not though.
|
|
||
| }; | ||
| if !found_significant_drop { | ||
| match expression.peel_drop_temps().kind { |
| #[clippy::version = "1.60.0"] | ||
| pub SIGNIFICANT_DROP_IN_SCRUTINEE, | ||
| nursery, | ||
| "default lint description" |
There was a problem hiding this comment.
You forgot to fill in this placeholder
|
Thank you for the initial review -- reviewing/merging an unstable version and iterating makes sense to me. I'll open a PR into the main repo. |
author Preston From <[email protected]> 1645164142 -0600 committer Preston From <[email protected]> 1650005351 -0600 parent e7575f9 author Preston From <[email protected]> 1645164142 -0600 committer Preston From <[email protected]> 1650005248 -0600 Lint for significant drops who may have surprising lifetimes #1
PrestonFrom
force-pushed
the
significant_drop
branch
from
6cb3237 to
96f8845
Compare
PrestonFrom
force-pushed
the
significant_drop
branch
from
96f8845 to
1e3119e
Compare
PrestonFrom
force-pushed
the
significant_drop
branch
from
1e3119e to
d90692a
Compare
author Preston From <[email protected]> 1645164142 -0600 committer Preston From <[email protected]> 1650005351 -0600
PrestonFrom
force-pushed
the
significant_drop
branch
from
3289065 to
d9e963f
Compare
Add new trait (
SignificantDrop) and lint to look for temporaries of types who implement it and who may have surprising lifetimes.