-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/one hot max indicator #3079
Conversation
_parse_port_spec(): enhance error message for bad MECHANISM entry in modulatory param specification
make matrix, auto, hetero and competition params non-modulable until that is implemented
- OneHot._function: add ARG_MAX, ARG_MAX_INDICATOR, ARG_MIN, ARG_MIN_INDICATOR
- OneHot: add arg_max, arg_max_indicator, arg_min, and arg_min_indicator options
WEIGHTED -> WEIGHTED_AVG
test warning for ARG_MAX or PROBABILISTIC with enable_learning = True
- OneHot: - add ARG_MAX_ABS, ARG_MAX_ABS_INDICATOR, ARG_MIN_ABS, ARG_MIN_ABS_INDICATOR - change default mode to ARG_MAX - relabel options for _gen_llvm from XXX_VAL to ARG_XXX • memoryfunctions.py - DictionaryMemory._gen_llvm_function_body: replace MIN_VAL with ARG_MIN in selection.function.mode • test_selection.py - test_basic: add tests of OneHot for ARG_XXX - exclude LLVM tests for XXX_VAL • test_transfer.py - test_basic: add tests of SoftMax for ARG_XXX - exclude LLVM tests for XXX__VAL
…tonUniversity/PsyNeuLink into fix/one_hot_max_indicator
…Link into fix/one_hot_max_indicator # Conflicts: # psyneulink/core/components/functions/nonstateful/selectionfunctions.py # tests/functions/test_selection.py # tests/functions/test_transfer.py
@@ -85,7 +85,7 @@ | |||
get_matrix, is_function_type, | |||
) | |||
from psyneulink.core.components.functions.nonstateful.combinationfunctions import LinearCombination | |||
from psyneulink.core.components.functions.nonstateful.selectionfunctions import OneHot | |||
from psyneulink.core.components.functions.nonstateful.selectionfunctions import OneHot, ARG_MAX, ARG_MAX_INDICATOR |
Check notice
Code scanning / CodeQL
Cyclic import Note
psyneulink.core.components.functions.nonstateful.selectionfunctions
from psyneulink.core.components.functions.nonstateful.selectionfunctions import OneHot, ARG_MAX, ARG_MAX_ABS, \ | ||
ARG_MAX_INDICATOR, ARG_MAX_ABS_INDICATOR |
Check notice
Code scanning / CodeQL
Cyclic import Note
psyneulink.core.components.functions.nonstateful.selectionfunctions
@@ -5,6 +5,7 @@ | |||
from psyneulink.core.components.functions.function import FunctionError | |||
from psyneulink.core.components.functions.stateful.memoryfunctions import DictionaryMemory, \ | |||
ContentAddressableMemory | |||
from psyneulink.core.components.functions.nonstateful.selectionfunctions import OneHot, ARG_MIN |
Check notice
Code scanning / CodeQL
Unused import Note test
Import of 'ARG_MIN' is not used.
from psyneulink.core.components.functions.nonstateful.selectionfunctions import ( | ||
ARG_MAX, ARG_MAX_ABS_INDICATOR, ARG_MAX_INDICATOR) |
Check notice
Code scanning / CodeQL
Unused import Note test
Import of 'ARG_MAX_ABS_INDICATOR' is not used.
Import of 'ARG_MAX_INDICATOR' is not used.
This PR causes the following changes to the html docs (ubuntu-latest-3.11):
See CI logs for the full diff. |
- move ARG_XXX keywords to keywords.py
This PR causes the following changes to the html docs (ubuntu-latest-3.11):
See CI logs for the full diff. |
This PR causes the following changes to the html docs (ubuntu-latest-3.11):
See CI logs for the full diff. |
…tonUniversity/PsyNeuLink into fix/one_hot_max_indicator
This PR causes the following changes to the html docs (ubuntu-latest-3.11):
See CI logs for the full diff. |
This PR causes the following changes to the html docs (ubuntu-latest-3.11):
See CI logs for the full diff. |
This PR causes the following changes to the html docs (ubuntu-latest-3.11):
See CI logs for the full diff. |
This PR causes the following changes to the html docs (ubuntu-latest-3.11):
See CI logs for the full diff. |
• transferfunctions.py
- OneHot:
- add ARG_MAX_ABS, ARG_MAX_ABS_INDICATOR, ARG_MIN_ABS, ARG_MIN_ABS_INDICATOR
- change default mode to ARG_MAX
- relabel options for _gen_llvm from XXX_VAL to ARG_XXX (former need to be implemented)
• memoryfunctions.py
- DictionaryMemory._gen_llvm_function_body: replace MIN_VAL with ARG_MIN for selection.function.mode
• emcomposition.py
- field_inputs_nodes -> input_nodes_by_fields
- refactor naming of retrieval nodes to
use input_nodes_by_fields
• test_selection.py
- test_basic: add tests of OneHot for ARG_XXX
- exclude LLVM tests for XXX_VAL
• test_transfer.py
- test_basic: add tests of SoftMax for ARG_XXX
- exclude LLVM tests for XXX__VAL
• test_emcomposition.py
- reinstate test_two_calls_no_args