Add Elm (elm-lang.org) support #1174

zwilias · 2017-08-17T10:47:14Z

No description provided.

Golmote

Hi! Thanks for this great PR! Please take a look at my review.

You might also want to add an example file: see https://github.com/PrismJS/prism/tree/gh-pages/examples

Golmote · 2017-09-09T11:12:57Z

components/prism-elm.js

+		// The imported or hidden names are not included in this import
+		// statement. This is because we want to highlight those exactly like
+		// we do for the names in the program.
+		pattern: /(\r?\n|\r|^)\s*import\s+([A-Z][_a-zA-Z0-9]*)(\.[A-Z][_a-zA-Z0-9]*)*(\s+as\s+([A-Z][_a-zA-Z0-9]*)(\.[A-Z][_a-zA-Z0-9]*)*)?(\s+exposing\s+)?/m,


Do you really need to capture the line-feed at the beginning? Isn't the ^ anchor enough with the m flag?

Occurrences of [_a-zA-Z0-9] should be simplified as \w.

There is no need for the parentheses around ([A-Z][_a-zA-Z0-9]*).

Golmote · 2017-09-09T11:15:16Z

components/prism-elm.js

+		pattern: /(^|[^-!#$%*+=?&@|~.:<>^\\\/])(--[^-!#$%*+=?&@|~.:<>^\\\/].*|{-[\s\S]*?-})/m,
+		lookbehind: true
+	},
+	char: /'([^\\']|\\([abfnrtv\\"'&]|\^[A-Z@[\]\^_]|NUL|SOH|STX|ETX|EOT|ENQ|ACK|BEL|BS|HT|LF|VT|FF|CR|SO|SI|DLE|DC1|DC2|DC3|DC4|NAK|SYN|ETB|CAN|EM|SUB|ESC|FS|GS|RS|US|SP|DEL|\d+|o[0-7]+|x[0-9a-fA-F]+))'/,


This looks quite overkill to me. Remember that Prism is not a linter.
Is there any case where a single-quoted string of characters should not be highlighted as char? If there isn't, you should be able to drastically simplify this regexp.

Also, you might want to add the greedy flag, here.

Yeah, upon closer inspection, I think /'([^\\']|\\([abfnrtv']|\d+|x[0-9a-fA-F]+))'/ will do - any single character (except ' itself) or an escape sequence which comes in a few forms. Thanks!

Golmote · 2017-09-09T11:16:58Z

components/prism-elm.js

+	},
+	char: /'([^\\']|\\([abfnrtv\\"'&]|\^[A-Z@[\]\^_]|NUL|SOH|STX|ETX|EOT|ENQ|ACK|BEL|BS|HT|LF|VT|FF|CR|SO|SI|DLE|DC1|DC2|DC3|DC4|NAK|SYN|ETB|CAN|EM|SUB|ESC|FS|GS|RS|US|SP|DEL|\d+|o[0-7]+|x[0-9a-fA-F]+))'/,
+	string: {
+		pattern: /"([^\\"]|\\([abfnrtv\\"'&]|\^[A-Z@[\]\^_]|NUL|SOH|STX|ETX|EOT|ENQ|ACK|BEL|BS|HT|LF|VT|FF|CR|SO|SI|DLE|DC1|DC2|DC3|DC4|NAK|SYN|ETB|CAN|EM|SUB|ESC|FS|GS|RS|US|SP|DEL|\d+|o[0-7]+|x[0-9a-fA-F]+)|\\\s+\\)*"/,


Same comment here: this looks overcomplicated. Are there string-like patterns in Elm that are not to be highlighted as string?

You're right, this is way overcomplicated. I adapted it from the haskell one; and I'm now realizing that - other than being overcomplicated - it's also wrong. Elm doesn't do multiline strings that way, but rather with """. Trying to figure out a good way to match either simple strings or multiline strings, which is slightly complicated by the latter being able to include single ".

Golmote · 2017-09-09T11:20:54Z

components/prism-elm.js

+	// operator too.
+	operator: /\s\.\s|[-!#$%*+=?&@|~.:<>^\\\/]*\.[-!#$%*+=?&@|~.:<>^\\\/]+|[-!#$%*+=?&@|~.:<>^\\\/]+\.[-!#$%*+=?&@|~.:<>^\\\/]*|[-!#$%*+=?&@|~:<>^\\\/]+|`([A-Z][_a-zA-Z0-9']*\.)*[_a-z][_a-zA-Z0-9']*`/,
+	// In Elm, nearly everything is a variable, do not highlight these.
+	hvariable: /\b([A-Z][_a-zA-Z0-9]*\.)*[_a-z][_a-zA-Z0-9]*\b/,


Occurrences of [_a-zA-Z0-9] should be replaced with \w.

Golmote · 2017-09-09T11:21:29Z

components/prism-elm.js

+	operator: /\s\.\s|[-!#$%*+=?&@|~.:<>^\\\/]*\.[-!#$%*+=?&@|~.:<>^\\\/]+|[-!#$%*+=?&@|~.:<>^\\\/]+\.[-!#$%*+=?&@|~.:<>^\\\/]*|[-!#$%*+=?&@|~:<>^\\\/]+|`([A-Z][_a-zA-Z0-9']*\.)*[_a-z][_a-zA-Z0-9']*`/,
+	// In Elm, nearly everything is a variable, do not highlight these.
+	hvariable: /\b([A-Z][_a-zA-Z0-9]*\.)*[_a-z][_a-zA-Z0-9]*\b/,
+	constant: /\b([A-Z][_a-zA-Z0-9]*\.)*[A-Z][_a-zA-Z0-9]*\b/,


Occurrences of [_a-zA-Z0-9] should be replaced with \w.

Golmote · 2017-09-09T11:28:55Z

components/prism-elm.js

+	// It may also be a separator between a module name and an identifier => no
+	// operator. If it comes together with other special characters it is an
+	// operator too.
+	operator: /\s\.\s|[-!#$%*+=?&@|~.:<>^\\\/]*\.[-!#$%*+=?&@|~.:<>^\\\/]+|[-!#$%*+=?&@|~.:<>^\\\/]+\.[-!#$%*+=?&@|~.:<>^\\\/]*|[-!#$%*+=?&@|~:<>^\\\/]+|`([A-Z][_a-zA-Z0-9']*\.)*[_a-z][_a-zA-Z0-9']*`/,


Occurrences of [_a-zA-Z0-9'] should be replaced with [\w'].

I might be wrong, but couldn't the whole regexp be rewritten as this one?
(single dot | special char (including dot) appearing two or more times | special char alone (not including dot) | backtick stuff)
/\s\.\s|[-!#$%*+=?&@|~:<>^\\\/.]{2,}|[-!#$%*+=?&@|~:<>^\\\/]|`([A-Z][\w']*\.)*[_a-z][\w']*`/

Yep. I'm gonna have a look at the characters the actual Elm parser allows, which should allow me to scrap a few. I included the backtick stuff for compatibility with Elm 0.17 but I think there's no real point to doing that, especially with 0.19 coming close to release.

I'll simplify, thanks :)

kachkaev · 2017-12-14T17:49:14Z

Thanks a lot for this PR @zwilias! Just pinging here as it'd be great if you could respond to @Golmote's review. Looking forward to see elm highlighting in markdown-preview-enhanced atom & vscode plugins, which use PrismJS under the hood!

Perhaps, someone else from the elm community could help here? I'm very new to this language :–)

zwilias · 2017-12-14T22:05:56Z

Put it on my todo list; I'll try to get back to this asap. Thanks for the reminder, @kachkaev, and so sorry for dropping the ball here, @Golmote. <3

kachkaev · 2017-12-24T13:01:54Z

@zwilias can I help with anything?

zwilias · 2017-12-24T23:45:38Z

Finally got around to cleaning up the patterns and fixing a few more bugs 😅

Golmote

Thanks for the updates! I've added a few more comments.
Also, I'd prefer you only use capturing groups when they are needed ; that is, for the lookbehind feature and back references. All other groups should be made non-capturing using ?: (e.g. (?:foo) instead of (foo)).

Golmote · 2018-01-02T07:48:49Z

components/prism-elm.js

+	string: [
+		{
+			// Multiline strings are wrapped in triple ". Quotes may appear unescaped.
+			pattern: /"""((.|\s)*?(?="""))"""/,


Is there an actual need for the positive look-ahead here?
Also, can you rewrite (.|\s) as [\s\S]? It's what we use everywhere else as a match-everything token.

Golmote · 2018-01-02T07:50:05Z

tests/languages/elm/char_feature.test

@@ -7,6 +8,7 @@

 [
 	["char", "'a'"],
+  ["char", "'\\''"],


Can you use a tab to fix the indentation of this line please?

Golmote · 2018-01-02T07:50:51Z

tests/languages/elm/string_feature.test


 ----------------------------------------------------

 [
 	["string", "\"\""],
+  ["string", "\"regular string\""],


Same here, please use a tab.

kachkaev · 2018-01-08T12:00:47Z

@zwilias would you be happy to address @Golmote's comments? So few bits are left to amend! 🚀

kachkaev · 2018-01-11T22:44:34Z

ping @zwilias 🙌

kachkaev · 2018-01-15T08:45:59Z

Many thanks @zwilias! 👏 @Golmote do you think the PR can be now merged and produce a new PrismJS version?

Golmote · 2018-01-16T07:45:06Z

Nice! Thank you both for sticking around. Expect a new version release (1.10) during the week.

See PrismJS/prism#1174

Golmote · 2018-01-17T23:00:27Z

@zwilias @kachkaev And 1.10.0 is out and published on NPM! 🎉

* gh-pages: (326 commits) Add C++ platform-independent types (PrismJS#1271) Release 1.10.0 Unescaped markup plugin: Make it work with any language (PrismJS#1265) Previewers: New plugin combining previous plugins Previewer: Base, Previewer: Angle, Previewer: Color, Previewer: Easing, Previewer: Gradient and Previewer: Time. Fix PrismJS#913 (PrismJS#1244) Add Elm (elm-lang.org) support (PrismJS#1174) IchigoJam: Remove unneeded escape Run gulp add Io syntax (PrismJS#1251) package.json: add attribute `style` (PrismJS#1256) Add the C++11 raw string feature to the cpp language IchigoJam: Make strings greedy BASIC: Make strings greedy Run gulp Add support for IchigoJam BASIC (PrismJS#1246) Add support for 6502 assembly (PrismJS#1245) fix for autoloader plugin Run gulp and reorder components alphabetically Xeora Language implementation (PrismJS#1239) upgrade autoloader Release 1.9.0 ...

Add Elm (elm-lang.org) support

1bedcff

Golmote requested changes Sep 9, 2017

View reviewed changes

Golmote mentioned this pull request Oct 26, 2017

Can ELM be added to Syntax Highlighting? #1212

Closed

zwilias added 3 commits December 25, 2017 00:42

Merge remote-tracking branch 'prism/gh-pages' into gh-pages

035972d

Simplify patterns and fix a few things inherited from haskell

1790447

Add example and minified file

4aa8fed

Golmote requested changes Jan 2, 2018

View reviewed changes

Clean up comment pattern, drop redundant groups, tabs for indents

b3e3b6b

Golmote approved these changes Jan 16, 2018

View reviewed changes

Golmote merged commit d6da70e into PrismJS:gh-pages Jan 16, 2018

kachkaev added a commit to kachkaev/mume that referenced this pull request Jan 17, 2018

Add elm to prismjs

5803564

See PrismJS/prism#1174

kachkaev mentioned this pull request Jan 17, 2018

Elm syntax highlighting with PrismJS shd101wyy/crossnote#32

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Elm (elm-lang.org) support #1174

Add Elm (elm-lang.org) support #1174

zwilias commented Aug 17, 2017

Golmote left a comment

Golmote Sep 9, 2017

zwilias Dec 24, 2017

Golmote Sep 9, 2017

Golmote Sep 9, 2017

zwilias Dec 24, 2017

Golmote Sep 9, 2017

zwilias Dec 24, 2017

Golmote Sep 9, 2017

Golmote Sep 9, 2017

Golmote Sep 9, 2017

zwilias Dec 24, 2017

kachkaev commented Dec 14, 2017 •

edited

Loading

zwilias commented Dec 14, 2017

kachkaev commented Dec 24, 2017 •

edited

Loading

zwilias commented Dec 24, 2017

Golmote left a comment •

edited

Loading

Golmote Jan 2, 2018

Golmote Jan 2, 2018

Golmote Jan 2, 2018

kachkaev commented Jan 8, 2018 •

edited

Loading

kachkaev commented Jan 11, 2018

kachkaev commented Jan 15, 2018

Golmote commented Jan 16, 2018

Golmote commented Jan 17, 2018

Add Elm (elm-lang.org) support #1174

Add Elm (elm-lang.org) support #1174

Conversation

zwilias commented Aug 17, 2017

Golmote left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kachkaev commented Dec 14, 2017 • edited Loading

zwilias commented Dec 14, 2017

kachkaev commented Dec 24, 2017 • edited Loading

zwilias commented Dec 24, 2017

Golmote left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kachkaev commented Jan 8, 2018 • edited Loading

kachkaev commented Jan 11, 2018

kachkaev commented Jan 15, 2018

Golmote commented Jan 16, 2018

Golmote commented Jan 17, 2018

kachkaev commented Dec 14, 2017 •

edited

Loading

kachkaev commented Dec 24, 2017 •

edited

Loading

Golmote left a comment •

edited

Loading

kachkaev commented Jan 8, 2018 •

edited

Loading