Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LESS: Removed useless insertBefore #1629

Merged
merged 3 commits into from
Dec 1, 2018

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Nov 21, 2018

This PR removes an insertBefore call which was intended to swap the order of punctuation and function.
But as function is already before punctuation (in CSS), it doesn't do anything.

@mAAdhaTTah mAAdhaTTah merged commit 86d3179 into PrismJS:master Dec 1, 2018
@RunDevelopment RunDevelopment deleted the less-useless-insert branch December 1, 2018 18:25
ggrossetie pushed a commit to ggrossetie/prism that referenced this pull request Mar 11, 2019
Remove an `insertBefore` call which was intended to swap the order of `punctuation`
and `function`.  But as `function` is already before `punctuation` (in [CSS](https://github.com/PrismJS/prism/blob/master/components/prism-css.js#L18)), it doesn't do anything.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants