Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSX/TSX class-name with dot #1725

Merged

Conversation

RexSkz
Copy link
Contributor

@RexSkz RexSkz commented Feb 12, 2019

Support class names like <Tree.TreeNode.Item>.

@RunDevelopment
Copy link
Member

I really like this change but I also think that we should include a punctuation pattern for the dots.

@RexSkz
Copy link
Contributor Author

RexSkz commented Feb 12, 2019

It's easy to add punctuation inside, but both VSCode and GitHub treats dot as a normal character in JSX tag, and there's no other special characters in it, so I think it's not necessary to recognize dot here.

@RunDevelopment
Copy link
Member

Well, it is as you said, it's easy to add later on.

@RunDevelopment RunDevelopment merged commit 4362e42 into PrismJS:master Feb 12, 2019
@RunDevelopment
Copy link
Member

Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants