-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batching read / writes to improve performance #1865
Batching read / writes to improve performance #1865
Conversation
First of all, thank you for committing this fix! Now, please run gulp to update the minified files (that's why the build failed). |
29c5f01
to
af25528
Compare
af25528
to
18b56fb
Compare
@RunDevelopment Hopefully this resolves the issues, should now include the changes to the file and the updated min file. |
Yup, that works! Thank you! |
That's ok, sorry for making a bit of a mess of this PR. But we got there in the end. |
I will fully review your PR soon. |
I made you a PR with a few improvements. Also, could you please provide an example which shows the reflow problem? |
@RunDevelopment , depending on your hardware, you should be able to see the problem on this page: https://www.bitovi.com/academy/learn-angular/creating-components.html. This was the page the original issue's performance graph was made from. Since that time, I've split that page into another page to improve the performance. Despite this I can still visually see a delay when I resize the window. You can see this in the following GIF. Notice that as I resize to see more of the screen, the "new" parts are white for a few ms. With this fix, resizing feels instantaneous. |
@justinbmeyer Thanks for sharing this! Hopefully, the page-splitting won't be necessary anymore after this fix. |
I have merged the changes made to this branch, so we should be good to go now. Thanks all |
When do you think this might be part of a release? Thanks! |
We don't have a fixed release schedule, so I can't say with certainty when a new version gets released. In the meantime, you can always get the latest version of Prism at our download page. This version includes this PR. |
Sorry to bother again, but any chance you'll be releasing soon? I'd like to avoid changing our packages from using |
This PR improves performance by batching the read / writes.
Related to - #1860 (comment)