Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for Latte & NEON #2140

Merged
merged 3 commits into from
Jan 5, 2020
Merged

added support for Latte & NEON #2140

merged 3 commits into from
Jan 5, 2020

Conversation

dg
Copy link
Contributor

@dg dg commented Dec 19, 2019

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing these languages @dg!

There are only a few things we'll have to address before merging this.
And please add a JSON test file for Neon. Just a simple test which shows that Neon is indeed a superset of JSON.

P.S. I saw that you're already using these languages on the Nette website and they look great!

components/prism-latte.js Outdated Show resolved Hide resolved
components/prism-latte.js Outdated Show resolved Hide resolved
components/prism-latte.js Show resolved Hide resolved
components/prism-neon.js Outdated Show resolved Hide resolved
components/prism-neon.js Show resolved Hide resolved
components/prism-neon.js Outdated Show resolved Hide resolved
components/prism-neon.js Outdated Show resolved Hide resolved
@dg
Copy link
Contributor Author

dg commented Dec 19, 2019

P.S. I saw that you're already using these languages on the Nette website and they look great!

Yes, Prism is really great tool! And it's fun to create new languages. Thanks for feedback.

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now!

We're currently in the process of publishing the next version of Prism, so I will merge your PR soon.

@dg
Copy link
Contributor Author

dg commented Dec 20, 2019

Thanks Michael!

@RunDevelopment RunDevelopment merged commit 694a81b into PrismJS:master Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants