-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Minified CSS using gulp-clean-css API #2553
Conversation
Thank you for making this PR @ashwinjayan! @ashwinjayan @mAAdhaTTah @LeaVerou @Golmote Note: If we added the minified files, we should also add support for this to the download page (shouldn't be too hard). However, changes to the download page shouldn't be part of this PR, IMO. Thoughts? |
to dev dependencies
Hi @RunDevelopment, I missed to save the dependency. Have added it to dev-dependency and committed. |
linkify, | ||
changes | ||
}; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, but this should keep the newline.
@RunDevelopment How hard would it be to add to the download page? @ashwinjayan Is this something you'd be willing to tackle? I do think it's a little curious we provide the JS minified and not the CSS so I'm open to adding this, but we should probs include the download page change as part of this. |
Pretty easy from what I see. If plugin CSS was also minified, then this is the only line that has to be changed. |
I'll close this now in favor of #3073. |
Minified css automatically generated using gulp-clean-css added to gulpfile.js folder