-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding basic support for mathematica #2921
Conversation
Support for the wolfram language: - Followed "new language" tutorial - Added html examples and test files - Initial work highlights basic common expressions including numbers, system-level symbols, comments, operators, and strings
JS File Size Changes (gzipped)A total of 3 files have changed, with a combined diff of +585 B (+12.9%).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this language definition @msollami!
I left you a few comments with things to improve.
Also, I have a question about class-name
and regex
: Are these really class names/regexes? I don't know Mathematica but the patterns don't look like that to me.
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Co-authored-by: Michael Schmidt <[email protected]>
Moved string rule after comment to make highlighting faster.
Added the alias 'mathematica'
@RunDevelopment Thanks for your review & help, this looks good to me now. |
Sorry, it was quite late for me yesterday. I agree that it's pretty much gtg now. We can merge this after the lining errors and my last comment have been addressed. |
Co-authored-by: Michael Schmidt <[email protected]>
Fixing linter errors
@RunDevelopment Ok, I added a new line at the end of file; changed tabs to spaces; and removed trailing whitespace, so the linter should be happy now. Is there a way I can trigger the action to run the linter? |
No, I have to trigger this manually every time. But all the CI does is run |
Good to know! Ok, it now passes the linter checks locally. |
Thank you for contributing @msollami! |
Support for the wolfram language: