Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional keywords for Elixir #2958

Merged
merged 6 commits into from
Jun 21, 2021

Conversation

ben-dyer
Copy link
Contributor

Add defmacro, quote and unquote keywords for elixir (cf. https://hexdocs.pm/elixir/1.12/syntax-reference.html#the-elixir-ast) and also added defn for numerical definition (https://github.com/elixir-nx/nx/tree/main/nx#numerical-definitions)

@github-actions
Copy link

github-actions bot commented Jun 21, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +13 B (+1.5%).

file master pull size diff % diff
components/prism-elixir.min.js 844 B 857 B +13 B +1.5%

Generated by 🚫 dangerJS against 275542d

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @ben-dyer!

Please add the new keywords to Elixir's keyword test (more info).

Also, we commit the minified files as well. Please run npm ci && npm run build and commit the changes.

@ben-dyer
Copy link
Contributor Author

@RunDevelopment Thanks for the help 🙇

@RunDevelopment
Copy link
Member

Nice.

Thank you for contributing @ben-dyer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants