Added initial LaTeX support #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Is there anyone here that actually knows LaTeX to review this? |
| 'comment': /%[\w\W]*/g, | ||
| 'string': /(\$)(\\?.)*?\1/g, | ||
| 'punctuation': /[\{\}]/g, | ||
| 'selector': /[\\][a-zA-Z;,:\.]*/g |
There was a problem hiding this comment.
- A character class with only 1 character is pointless, just use
\\instead of[\\] - You can avoid
a-zA-Zby using theiflag to make it case insensitive
There was a problem hiding this comment.
Also [\w\W]* will match the whole file, but Latex uses one line comments. It should be something like: 'comment': /%.*?(\r?\n|$)/g,
There was a problem hiding this comment.
Or you can use the m flag and add a $ so that it only matches the line
|
Thanks for the suggestions! I merged that into the files now. Ran it just now on some massive files we used for our graduation project and everything seemed to be highlighted just fine. |
|
Merged, thanks :) |
|
I just pushed the minified version. |
|
Thanks Jannik! |
|
Awesome. Thanks both :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of pull #207 on issue #206