Remove the need for an "output" class. #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var node = prompt.children[j - 1]; | ||
| node.removeAttribute('data-user'); | ||
| node.removeAttribute('data-host'); | ||
| node.removeAttribute('data-prompt'); |
There was a problem hiding this comment.
How about something like:
["user", "host", "prompt"].forEach(function(attr) { node.removeAttribute("data-" + attr); });There was a problem hiding this comment.
In my opinion, the original code is cleaner and easier to read. It's "nice" that it could be done in 1 line, but saving those 18 characters effectively adds 4 function calls and 3 string concatenations.
There was a problem hiding this comment.
It’s not about doing it in one line, it's about removing repetition. Actually, I wouldn't do it in one line, I would format it as 3, for readability. Anyhow, no strong opinion here.
|
Thanks! LGTM, see comment :) |
LeaVerou
added a commit
that referenced
this pull request
Jan 2, 2016
Remove the need for an "output" class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zeitgeist87: These are the changes you suggested in PR #831.