Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update team with 2020-2021 board #14

Merged
merged 9 commits into from
Apr 1, 2020

Conversation

JoshiNaman
Copy link
Collaborator

Updated members page and mentor section

@shrijitsingh99
Copy link
Collaborator

Either you can be a mentor or member. For the remaining people, we can create a new section (#15). So this needs fixing.

Is the mentor list up to date, confirm once.

The page seems too long to, maybe a view more button? @Sarath18

@Sarath18
Copy link
Contributor

Sarath18 commented Apr 1, 2020

Sounds like a good idea. Year wise team section will go hand in hand with this.

@shrijitsingh99
Copy link
Collaborator

Then for now let us just add the new team, and we can update the mentor list in a separate PR.
Don't think anyone will mind, for the time being, parallelly we develop #15,
@Sarath18 let discuss any mockups over there.

@JoshiNaman Please update only the team list and remove any senior members, don't add or remove any mentors for now.

@JoshiNaman
Copy link
Collaborator Author

add the new team as in only the 2nd years, right? and take out the third years from the mentor section for the time being

@shrijitsingh99
Copy link
Collaborator

add the new team as in only the 2nd years, right? and take out the third years from the mentor section for the time being

Yup, remove current 3rd years from mentors list, as well as team. We can add them back after the year wise section is developed.

@aneesh404
Copy link
Collaborator

@JoshiNaman Parthesh Savla and Gaurav Thakur are in third year, remove them from team section.

@JoshiNaman
Copy link
Collaborator Author

i have made the changes to the branch, do I have to put the pull request again or it updates itself
I have pushed the changes

_data/mentors.yaml Outdated Show resolved Hide resolved
_site/index.html Outdated Show resolved Hide resolved
@shrijitsingh99 shrijitsingh99 changed the title Updated members and mentors Update team with 2020-2021 board Apr 1, 2020
@shrijitsingh99
Copy link
Collaborator

shrijitsingh99 commented Apr 1, 2020

It auto-updates.
Just a tip for future, read this on how to write good commit messages.
Commit messages allows people later to understand what change was done in that commit, without going through the changed code.

For this time will just squash the commits, since its a small change.

@shrijitsingh99
Copy link
Collaborator

Omkar also needs to be removed, Akhil is Automation Head, that needs to be added.

JoshiNaman and others added 3 commits April 2, 2020 04:45
…tmanas.in into update-Members

Could not push the changes made because current branch is behind

Merge branch 'update-Members' of https://github.com/JoshiNaman/projectmanas.in into update-Members

Could not push the changes made because current branch is behind
@shrijitsingh99 shrijitsingh99 self-requested a review April 1, 2020 23:31
@shrijitsingh99 shrijitsingh99 merged commit 2992a19 into Project-MANAS:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants