-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compose cannot work with both Decollated and MultiSampleTrait transforms #8186
Comments
KumoLiu
added a commit
to KumoLiu/MONAI
that referenced
this issue
Nov 1, 2024
Signed-off-by: YunLiu <[email protected]>
KumoLiu
added a commit
to KumoLiu/MONAI
that referenced
this issue
Nov 1, 2024
Signed-off-by: YunLiu <[email protected]>
7 tasks
KumoLiu
added a commit
that referenced
this issue
Feb 12, 2025
Fixes #8186. ### Description A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <[email protected]> Co-authored-by: Ben Murray <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
thibaultdvx
pushed a commit
to thibaultdvx/MONAI
that referenced
this issue
Feb 13, 2025
Fixes Project-MONAI#8186. ### Description A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <[email protected]> Co-authored-by: Ben Murray <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If
Compose
is used with the following types of transforms, the third transform will not get the expected input:Decollated
, which splits the input. This transform looks like:MultiSampleTrait
, which further splits the input. Note that the accumulated effect is now:MapTransform
, which expect adict[str, Tensor]
from the caller (Compose
in this case), will error.To Reproduce
Code snippet:
This will error:
Expected behavior
Right now I can get around this by inserting a custom transform that flattens the nested list. But
Compose
should handle this just like it handles usualMultiSampleTrait
transforms.Environment
The text was updated successfully, but these errors were encountered: