Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix md5 hashing with FIPS mode #6635

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Fix md5 hashing with FIPS mode #6635

merged 4 commits into from
Jun 21, 2023

Conversation

MattTheCuber
Copy link
Contributor

Description

MD5 hashing is not allowed in FIPS enabled machines for security. A simple fix is to use the usedforsecurity=False flag in the md5() calls.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli
wyli reviewed Jun 21, 2023
View reviewed changes
monai/data/utils.py Outdated Show resolved Hide resolved
@wyli
Copy link
Contributor

wyli commented Jun 21, 2023

/black

wyli
wyli approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Contributor

wyli commented Jun 21, 2023

/build

@wyli wyli enabled auto-merge (squash) June 21, 2023 13:59
@monai-bot @wyli
[MONAI] code formatting
8043112 
Signed-off-by: monai-bot <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Contributor

wyli commented Jun 21, 2023

/build

1 similar comment
@wyli
Copy link
Contributor

wyli commented Jun 21, 2023

/build

@wyli wyli merged commit e475196 into Project-MONAI:dev Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MattTheCuber @wyli @monai-bot