-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in_mm3
in remove_small_objects
#7137
Conversation
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
In this PR, I added the
@AHarouni, could you please check whether this one can help address your issue? |
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: KumoLiu <[email protected]>
Co-authored-by: Wenqi Li <[email protected]> Signed-off-by: YunLiu <[email protected]>
Co-authored-by: Wenqi Li <[email protected]> Signed-off-by: YunLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks good to me.
physical_scale
in remove_small_objects
in_mm3
in remove_small_objects
Signed-off-by: KumoLiu <[email protected]>
/build |
This assumes the images are 3D, what about 2D? mm^3 isn't the unit being used in that case. Also we haven't specified what units we're working in, I would just state that the measure is in unit area or volume and not assume units are mm. Typically we resample in terms of square or cubic mm but not always and we don't encode in types or anywhere else what units we're dealing with, they've elsewhere always been implicit. |
Signed-off-by: KumoLiu <[email protected]>
/build |
/build |
Fixes #7034.
Description
Add
in_mm3
inremove_small_objects
, ifin_mm3=True
,min_size
will be divided by pixdim when the image is MetaTensor.Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.