Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example apps' test data path, patch hsdk in local env, and ensure correct MD SDK is used in dev env #516

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

MMelQin
Copy link
Collaborator

@MMelQin MMelQin commented Jan 17, 2025

This PR intends to fix multiple issues reported lately.

  • When testing in dev env with CLI packager, holoscan was not installed in MAP. The root cause is NOT the packager. The local monai-deploy-app-sdk editable package's PKG-INFO has the version of 0.5.1+24.gc60696a.dirty, obviously wrong as it should be 2.0.0+xxx, as and as such, the CLI reads the version and pip installs monai-deploy-app-sdk 0.5.1 from pypi.org. The reason for setting the wrong version of monai deploy app sdk is because that versioneer is used, and it calls _version.py, which in turn uses Git to query the Github repo for the latest version. Somehow, Github repo version was not tagged/set correctly since 0.5.1.
    Changed to use the _version.py generated on bumping version
  • The second issue is in holoscan sdk v2.8 (in v2.7 also), with the missing MultiMessageConditonInfo in import. The fix will be in v2.9. A post install action has been added to the setup.py, to patch locally installed holoscan sdk
  • Until a new MONAI Deploy App SDK package is released, the aforementioned patching action would not be available when a user installs the MD App SDK from pypi.org. To workaround the issue, the user can run the same script to patch the installed holoscan package, but packaging the app with CLI Packager will not have the holoscan patched in the MAP image, hence, adding the holoscan==2.6.0 to the apps' requirements.txt file is the workaround
  • Security policy changes have prevented sharing the application test data file anonymously, and the hosted files have changed locations. Hence the examples have been updated with new instructions and URLs

@MMelQin MMelQin requested review from mocsharp and gigony January 17, 2025 03:47
setup.py Show resolved Hide resolved
@MMelQin MMelQin merged commit 7de1e62 into main Jan 17, 2025
4 checks passed
MMelQin added a commit that referenced this pull request Jan 23, 2025
…ure correct MD SDK is used in dev env (#516)

* Add post intall action to patch holoscan package, v2.7 and 2.8

Signed-off-by: M Q <[email protected]>

* Update fixed turorials

Signed-off-by: M Q <[email protected]>

* Updated the setup post install action, local sdk version, and notebook examples

Signed-off-by: M Q <[email protected]>

* Updated the doc too

Signed-off-by: M Q <[email protected]>

* Fix linting error

Signed-off-by: M Q <[email protected]>

---------

Signed-off-by: M Q <[email protected]>
MMelQin added a commit that referenced this pull request Jan 23, 2025
…a numpy array (#515)

* Fix for case where input image is already a numpy array

Signed-off-by: Chris Bridge <[email protected]>

* Update example apps' test data path, patch hsdk in local env, and ensure correct MD SDK is used in dev env (#516)

* Add post intall action to patch holoscan package, v2.7 and 2.8

Signed-off-by: M Q <[email protected]>

* Update fixed turorials

Signed-off-by: M Q <[email protected]>

* Updated the setup post install action, local sdk version, and notebook examples

Signed-off-by: M Q <[email protected]>

* Updated the doc too

Signed-off-by: M Q <[email protected]>

* Fix linting error

Signed-off-by: M Q <[email protected]>

---------

Signed-off-by: M Q <[email protected]>

---------

Signed-off-by: Chris Bridge <[email protected]>
Signed-off-by: M Q <[email protected]>
Co-authored-by: Ming M Qin <[email protected]>
@MMelQin MMelQin deleted the mq/patch_hsdk_and_update_testdata branch February 3, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants