This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
Cleather/papermill deck #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 27, 2022 21:05
Signed-off-by: Calvin Leather <[email protected]>
Signed-off-by: Calvin Leather <[email protected]>
Signed-off-by: Calvin Leather <[email protected]>
CalvinLeather
force-pushed
the
cleather/papermill-deck
branch
from
7815b53 to
964fbc7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR modifies the papermill plugin so that, if render_deck=True is passed to init, the rendered output html is inserted as a flyte deck.
Type
Are all requirements met?
Complete description
This PR modifies the papermill plugin so that, if a kwarg render_deck is passed, the flyte deck is added automatically, without need for a follow up task. The render_deck kwarg was used to ensure backwards compatibility, by default, the behaviour of the papermill plugin won't be changed (i.e., this deck support is opt-in).
Note that this won't happen for cached execution, there is an open issue out for fixing flyte decks for cached execution.
I tested this change by installing this branch of flytekit into a container and registering one of our company's test notebook tasks, and running it. It gets a deck as intended:
Note 100% happy with how I tested this plugin. Since the unit tests use local execution, the deck/context functionality I think isn't getting used. Let me know if there is a better way to do test this.
Tracking Issue
n/a (can open an issue if you like, JFDI'd this after discussing with Ketan here)
Follow-up issue
NA