Skip to content

Commit

Permalink
chore/upgrade greenwood v0.30.0 (#20)
Browse files Browse the repository at this point in the history
* upgrade greenwood v0.30.0-alpha.0

* add patches

* upgrade greenwood alpha.1

* bump to alpha.2 release

* bump to greenwood v0.30.0-alpha.3

* upgrade v0.30.0-alpha.4

* upgrade alpha.6

* bump to greenwood v0.30.0-alpha.7

* v0.30.0 final
  • Loading branch information
thescientist13 authored Nov 2, 2024
1 parent dc4c6a6 commit bf0986a
Show file tree
Hide file tree
Showing 8 changed files with 1,244 additions and 420 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.12.1
18.20.2
21 changes: 1 addition & 20 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,6 @@ So although this runs fine locally for `/api/fragment-manual`, when run on Netli
![Netlify ERR_REQUIRE_ESM](./netlify-err-require-esm.png)
## Edge
TODO
Expand All @@ -140,21 +138,4 @@ TODO
TODO
### SSR page
TODO
## Adapter Implementation Thoughts / Questions
1. [x] Do we even need workers for build output?
- if not, how to make a generic solution? (make a pure `executeModule` function and run the worker ourselves when needed in dev mode?)
1. [x] Will need to generate the _.netlify/functions_ folder on-demand / as part of the build instead of hardcoding, likely from _manifest.json_
1. [x] For SSR pages, manual is the only option? That will impact how pages can be built, e.g. manual card, shadow dom, etc and might to be configurable based on if the platform supports `import.meta.url` or not it seems.
- we can get around this using our own bundling solution - https://docs.netlify.com/functions/deploy/?fn-language=js#custom-build-2
1. [x] How to best manage local dev (runtime "compliance") - mixed support, see caveats section of the plugin's README
- proxy netlify cli dev option?
- should use _src/_ or _public/_? depends on dev vs production mode? Interestingly, the manual way only worked deployed when using _public/_
- if esbuild worked w/ `import.meta.url`, we could probably ship unzipped bundles, and then dev would also work?
1. [x] Need to provide custom _netlify.toml_?
1. [x] Make sure to spread all headers / response properties in netlify functions adapter output
1. [ ] SSR pages are bundling into _public/api/_ directory ?
1. [ ] Keep it as an experimental feature for 1.0 (or per platform?)
### SSR page
Loading

0 comments on commit bf0986a

Please sign in to comment.