Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/issue 923 real production import attributes #1259

Merged
merged 9 commits into from
Jul 31, 2024
Merged

enhancement/issue 923 real production import attributes #1259

merged 9 commits into from
Jul 31, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jul 20, 2024 •
edited
Loading

Related Issue

#923 / #1216

See a prototype here - ProjectEvergreen/www.greenwoodjs.dev#74

Summary of Changes

  1. Support "real" import attributes for production browser bundles
  2. Add documentation

This is mainly a breaking change to plugins.

TODOs

  1. get all test cases back to passing for SSR bundles
  2. website not bundling correctly on ?type=raw resources in a production build
    ![Screenshot 2024-07-20 at 9 38 58 AM](https://github.com/user-attachments/assets/cb425532-7ce7-4dfa-88bc-69ba0a4656a4)
  3. smoke this and feature/issue 1257 CSS optimization workflow parity #1258 with downstreams
  4. update tests for new behavior for browser bundles
    • import instead of "raw" CSS
    • test for output file bundles now (no more in lining / import ref mapping)
  5. need to handle inline optimization bundle mapping edge case (see chore/upgrade greenwood v0.30.0 AnalogStudiosRI/www.analogstudios.net#98)
  6. should rename this to something like getRollupConfigForBrowser
  7. clean up console logging / commented out code / add clarifying comments to rollup.config.js
  8. documentation updates with an example of Constructable Stylesheets in styles and assets section
  9. update Isomorphic (Reflected) Import Attributes Support #1216 (comment) with the latest state of this implementation - Isomorphic (Reflected) Import Attributes Support #1216 (comment)
  10. handle basePath
  11. how to exclude module.css? (nice to have)

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) documentation Greenwood specific docs CLI labels Jul 20, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Jul 20, 2024
@thescientist13 thescientist13 self-assigned this Jul 20, 2024
@thescientist13 thescientist13 linked an issue Jul 20, 2024 that may be closed by this pull request
import attributes for standard module formats; CSS and JSON #923
Closed
3 tasks
This was referenced Jul 20, 2024
Merged
Merged
This was referenced Jul 21, 2024
Closed
Merged
@thescientist13 thescientist13 marked this pull request as ready for review July 24, 2024 13:03
@thescientist13 thescientist13 merged commit 205352e into release/0.30.0 Jul 31, 2024
8 checks passed
@thescientist13 thescientist13 deleted the feature/issue-923-real-production-import-attributes branch July 31, 2024 01:06
@thescientist13 thescientist13 mentioned this pull request Aug 3, 2024
Merged
3 tasks
@thescientist13 thescientist13 mentioned this pull request Aug 24, 2024
Closed
thescientist13 added a commit that referenced this pull request Nov 2, 2024
@thescientist13
enhancement/issue 923 real production import attributes (#1259)
898d1ad 
* WIP real production import attributes

* restore all test cases to passing

* all test cases and website building correctly

* rollup resolveId refactoring

* rename rollup configs to be more explicit

* refine test cases

* clean up console logs and TODOs

* add import attributes to the docs

* handle base path for bundled import attributes references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
alpha.5 breaking CLI documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc) v0.30.0
Projects
No open projects
[Greenwood] Phase 9 - Standards and Conventions
Status: ✅ Done
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

import attributes for standard module formats; CSS and JSON
1 participant
@thescientist13