Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route Based Code Splitting #265
Route Based Code Splitting #265
Changes from 3 commits
c888286
096a1d7
9bb4009
b1ea9e3
7ad4e7e
210a982
e0a2a0d
37d7f68
047df37
eaf4aeb
17305cb
4bfec57
8f5b7c1
d1f1144
949a1dc
a1bbfb2
097fedb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a shame we need a custom app-template.js just for a few lines of HTML. 🤔
I wonder if we could inherit from Greenwoood's
AppComponent
and just override just therender
method somehow??? That would be pretty slick...can probably be another issue, but would be good to play around with it now just to see what's possible, just to understand what can / can't be done.