Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove scrollbar #831

Merged
merged 2 commits into from
Dec 27, 2021
Merged

fix: remove scrollbar #831

merged 2 commits into from
Dec 27, 2021

Conversation

hutchgrant
Copy link
Member

Related Issue

Resolves #830

Summary of Changes

removes overflow:scroll

Copy link
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the scrollbar before but everything still looks OK, so take my ✅ with a grain of YMMV 🙃

Copy link
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this issue seemed familiar. Looks like we had attempted a fix for this before, interestingly enough - #735
@hutchgrant
Though I'm not opposed to merging given it is such a small change, can you confirm what version you see in the footer? (just to ensure no caching issues?)
Screen Shot 2021-12-21 at 12 44 54 PM

To me it looks the same before / after so I hesitate to be the final judge on this just yet. 👉 🥺 👈

@hutchgrant
Copy link
Member Author

image

@thescientist13 this is present on current version and upon checking the PR you referenced and its preview on netlify, it also was never fixed as overflow:scroll was still present.

image

@hutchgrant
Copy link
Member Author

Of course, my changes in this PR do in fact correctly fix the problem:

image

@hutchgrant
Copy link
Member Author

hutchgrant commented Dec 27, 2021

Further tests on browser stack with current greenwoodjs.io/docs, I did not see the scrollbars on mac chrome v96 or safari.

image

I did however see this on windows 10 + 11 chrome v96.

image

@thescientist13
Copy link
Member

thescientist13 commented Dec 27, 2021

Awesome, thanks for the extra context, plus the link you shared in Slack was super helpful and actually helped jog my memory on a similar issue I also ran into before here - thescientist13/greenwood-starter-presentation#50.

I fired up my Windows VM and yup, sure enough, there they were. 😢
Screen Shot 2021-12-27 at 12 44 23 PM

But thankfully switching to your branch fixed them! 🙌
Screen Shot 2021-12-27 at 12 47 59 PM

It's a festivus miracle!

@thescientist13 thescientist13 added the website Tasks related to the projects website / documentation label Dec 27, 2021
@thescientist13 thescientist13 merged commit 3428ae6 into master Dec 27, 2021
@thescientist13 thescientist13 deleted the fix/840-site-style-overflow branch December 27, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Tasks related to the projects website / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

greenwood website page style is displaying scroll bars
2 participants