-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove scrollbar #831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the scrollbar before but everything still looks OK, so take my ✅ with a grain of YMMV 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this issue seemed familiar. Looks like we had attempted a fix for this before, interestingly enough - #735
@hutchgrant
Though I'm not opposed to merging given it is such a small change, can you confirm what version you see in the footer? (just to ensure no caching issues?)
To me it looks the same before / after so I hesitate to be the final judge on this just yet. 👉 🥺 👈
@thescientist13 this is present on current version and upon checking the PR you referenced and its preview on netlify, it also was never fixed as overflow:scroll was still present. |
Awesome, thanks for the extra context, plus the link you shared in Slack was super helpful and actually helped jog my memory on a similar issue I also ran into before here - thescientist13/greenwood-starter-presentation#50. I fired up my Windows VM and yup, sure enough, there they were. 😢 But thankfully switching to your branch fixed them! 🙌 It's a festivus miracle! |
Related Issue
Resolves #830
Summary of Changes
removes
overflow:scroll