Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to manifesto.js wrapper constructors affect code in much of application #4100

Open
barmintor opened this issue Feb 12, 2025 · 0 comments · May be fixed by #4102
Open

Changes to manifesto.js wrapper constructors affect code in much of application #4100

barmintor opened this issue Feb 12, 2025 · 0 comments · May be fixed by #4102

Comments

@barmintor
Copy link
Contributor

Using selectors and hooks may moderate the impact of changes to MiradorCanvas, MiradorManifest, CanvasWorld, and ThumbnailFactory
barmintor added a commit to cul/mirador that referenced this issue Feb 12, 2025
@barmintor
Move ThumbnailFactory and manifesto.js wrappers into selectors and hooks
28a1e77 
- prepare for auth2 service parsing changes
- prevent exposing wrapper constructor changes to wrappers to broad swathes of app
- stabilize empty object/array references for input selectors
- fixes ProjectMirador#4100
@barmintor barmintor mentioned this issue Feb 12, 2025
Closed
barmintor added a commit to cul/mirador that referenced this issue Feb 12, 2025
@barmintor
Move ThumbnailFactory and manifesto.js wrappers into selectors and hooks
fa1daf7 
- prepare for auth2 service parsing changes
- prevent exposing wrapper constructor changes to wrappers to broad swathes of app
- stabilize empty object/array references for input selectors
- fixes ProjectMirador#4100
barmintor added a commit to cul/mirador that referenced this issue Feb 12, 2025
@barmintor
Move ThumbnailFactory and manifesto.js wrappers into selectors and hooks
82dc6c0 
- prepare for auth2 service parsing changes
- prevent exposing wrapper constructor changes to wrappers to broad swathes of app
- stabilize empty object/array references for input selectors
- fixes ProjectMirador#4100
@barmintor barmintor linked a pull request Feb 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@barmintor