fix: nullable fields are optional when inserting

Fixes: #20
ProjectXero · Nov 30, 2020 · fba3e1c · fba3e1c
1 parent 4684631
commit fba3e1c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/generator/__tests__/__snapshots__/Generator.test.ts.snap b/src/generator/__tests__/__snapshots__/Generator.test.ts.snap
@@ -54,9 +54,9 @@ export interface TableWithNullableFields {
     nullable_array_with_default: string[] | null;
 }
 export interface TableWithNullableFields$Insert {
-    nullable: string | null;
+    nullable?: string | null;
     nullable_with_default?: string | null;
-    nullable_array: string[] | null;
+    nullable_array?: string[] | null;
     nullable_array_with_default?: string[] | null;
 }
 export const TableWithNullableFields$Types: Record<keyof TableWithNullableFields, string> = {
@@ -122,9 +122,9 @@ export interface TableWithNullableFields {
     nullableArrayWithDefault: string[] | null;
 }
 export interface TableWithNullableFields$Insert {
-    nullable: string | null;
+    nullable?: string | null;
     nullableWithDefault?: string | null;
-    nullableArray: string[] | null;
+    nullableArray?: string[] | null;
     nullableArrayWithDefault?: string[] | null;
 }
 export const TableWithNullableFields$Types: Record<keyof TableWithNullableFields, string> = {
@@ -161,9 +161,9 @@ export interface TableWithUuidId$Insert {
     id?: string;
 }
 export interface TableWithNullableFields$Insert {
-    nullable: string | null;
+    nullable?: string | null;
     nullable_with_default?: string | null;
-    nullable_array: string[] | null;
+    nullable_array?: string[] | null;
     nullable_array_with_default?: string[] | null;
 }
 "

diff --git a/src/generator/builders/InsertTypeBuilder.ts b/src/generator/builders/InsertTypeBuilder.ts
@@ -9,7 +9,7 @@ export default class InsertTypeBuilder extends TableBuilder {
       const builder = new ColumnBuilder(columnInfo, this.types, this.transform)
       let signature = builder.buildNode()
 
-      if (columnInfo.hasDefault) {
+      if (columnInfo.hasDefault || columnInfo.nullable) {
         signature = factory.updatePropertySignature(
           signature,
           signature.modifiers,