change quantile calculation implementation #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mp3000mp, thank you! Can you please Sign your Commit (DCO check fails (more details: https://github.com/PromPHP/prometheus_client_php/pull/81/checks?check_run_id=4461549662)). When this is signed we are good to go :) Thank you! |
Signed-off-by: Matthias Perret <[email protected]>
mp3000mp
force-pushed
the
feat/change-quantile-calculation-implementation
branch
from
bc917bc to
8ea3c2b
Compare
|
Done, thank you ! |
LKaemmerling
approved these changes
Dec 17, 2021
|
@mp3000mp thank you! Good job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This should fix the issue #78.
Signed-off-by: Matthias Perret [email protected]