Fixes #1838: don't append imports where no imports are present

PyCQA · Nov 3, 2021 · 73245e9 · 73245e9
1 parent 223dc4c
commit 73245e9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/isort/core.py b/isort/core.py
@@ -355,7 +355,7 @@ def process(
                 next_import_section = ""
 
             if import_section:
-                if add_imports and not indent:
+                if add_imports and (contains_imports or not config.append_only) and not indent:
                     import_section = (
                         line_separator.join(add_imports) + line_separator + import_section
                     )

diff --git a/tests/unit/test_ticketed_features.py b/tests/unit/test_ticketed_features.py
@@ -213,6 +213,19 @@ def test_isort_supports_append_only_imports_issue_727():
 """
     )
 
+    # issue 1838: don't append in middle of class
+    assert isort.check_code(
+        '''class C:
+    """a
+
+    """
+    # comment
+''',
+        append_only=True,
+        add_imports=["from __future__ import annotations"],
+        show_diff=True,
+    )
+
 
 def test_isort_supports_shared_profiles_issue_970():
     """Test to ensure isort provides a way to use shared profiles.